davidm-db commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1916456260
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala:
##########
@@ -63,6 +66,84 @@ case class SqlScriptingInterpreter(session: SparkSession) {
case _ => None
}
+ /**
+ * Transform [[CompoundBody]] into [[CompoundBodyExec]].
+ * @param compoundBody
+ * CompoundBody to be transformed into CompoundBodyExec.
+ * @param args
+ * A map of parameter names to SQL literal expressions.
+ * @param isExitHandler
+ * Flag to indicate if the body is an exit handler body to add leave
statement at the end.
+ * @param exitHandlerLabel
+ * If body is an exit handler body, this is the label of surrounding
CompoundBody
+ * that should be exited.
+ * @return
+ * Executable version of the CompoundBody .
+ */
+ private def transformBodyIntoExec(
+ compoundBody: CompoundBody,
+ args: Map[String, Expression],
+ context: SqlScriptingExecutionContext,
+ isExitHandler: Boolean = false,
+ exitHandlerLabel: String = ""): CompoundBodyExec = {
Review Comment:
parameter namings here as well - since nothing is specific to `EXIT`
handler, I wouldn't use "exit" anywhere.
I guess we can already set it up for the `CONTINUE` handler as well, maybe
by having `isHandler: Boolean = false`, `handlerType: Option[...] = None` and
`handlerLabel: String` (or `Option[String]`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
