davidm-db commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1916361249
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/SqlScriptingParserSuite.scala:
##########
@@ -2302,6 +2302,51 @@ class SqlScriptingParserSuite extends SparkFunSuite with
SQLHelper {
head.asInstanceOf[SingleStatement].getText == "SELECT 3")
}
+ test("declare condition: custom sqlstate") {
+ val sqlScriptText =
+ """
+ |BEGIN
+ | SELECT 1;
+ | DECLARE test CONDITION FOR SQLSTATE '12000';
+ |END""".stripMargin
+ val tree = parsePlan(sqlScriptText).asInstanceOf[CompoundBody]
+ assert(tree.conditions.size == 1)
+ assert(tree.conditions("test").equals("12000"))
+ }
+
+ ignore("declare condition: default sqlstate") {
+ val sqlScriptText =
+ """
+ |BEGIN
+ | DECLARE test CONDITION;
+ |END""".stripMargin
+ val tree = parsePlan(sqlScriptText).asInstanceOf[CompoundBody]
+ assert(tree.conditions.size == 1)
+ assert(tree.conditions("test").equals("45000")) // Default SQLSTATE
+ }
+
+ test("declare handler") {
+ val sqlScriptText =
+ """
+ |BEGIN
+ | DECLARE EXIT HANDLER FOR test BEGIN SELECT 1; END;
+ |END""".stripMargin
+ val tree = parsePlan(sqlScriptText).asInstanceOf[CompoundBody]
+ assert(tree.handlers.length == 1)
+ assert(tree.handlers.head.isInstanceOf[ErrorHandler])
+ }
+
+ test("declare handler single statement") {
+ val sqlScriptText =
+ """
+ |BEGIN
+ | DECLARE EXIT HANDLER FOR test SELECT 1 END;
+ |END""".stripMargin
+ val tree = parsePlan(sqlScriptText).asInstanceOf[CompoundBody]
+ assert(tree.handlers.length == 1)
+ assert(tree.handlers.head.isInstanceOf[ErrorHandler])
+ }
+
Review Comment:
Let's add validation that the handler body is properly set and that it has
the correct statement within it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
