davidm-db commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1916432559
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionContext.scala:
##########
@@ -50,20 +72,24 @@ class SqlScriptingExecutionContext {
* @param executionPlan CompoundBody which need to be executed.
*/
class SqlScriptingExecutionFrame(
- executionPlan: Iterator[CompoundStatementExec]) extends
Iterator[CompoundStatementExec] {
+ val executionPlan: CompoundBodyExec,
+ val frameType: SqlScriptingFrameType,
+ val scopeToExit: Option[String] = None) extends
Iterator[CompoundStatementExec] {
Review Comment:
nit: add params to the description
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingExecutionContext.scala:
##########
@@ -50,20 +72,24 @@ class SqlScriptingExecutionContext {
* @param executionPlan CompoundBody which need to be executed.
*/
class SqlScriptingExecutionFrame(
- executionPlan: Iterator[CompoundStatementExec]) extends
Iterator[CompoundStatementExec] {
+ val executionPlan: CompoundBodyExec,
+ val frameType: SqlScriptingFrameType,
+ val scopeToExit: Option[String] = None) extends
Iterator[CompoundStatementExec] {
Review Comment:
nit: add new params to the description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
