davidm-db commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1916350996
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -79,6 +81,29 @@ setStatementWithOptionalVarKeyword
LEFT_PAREN query RIGHT_PAREN
#setVariableWithOptionalKeyword
;
+sqlStateValue
+ : stringLit
+ ;
+
+declareConditionStatement
+ : DECLARE multipartIdentifier CONDITION (FOR SQLSTATE VALUE?
sqlStateValue)?
+ ;
+
+conditionValue
+ : sqlStateValue
Review Comment:
I'm talking about this part of the ref spec:
<img width="668" alt="image"
src="https://github.com/user-attachments/assets/16b0b5a7-8387-49e1-8052-cc2165e6f19a";
/>
Seems like we need to have `SQLSTATE VALUE? sqlStateValue` in the handler
declaration as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
