davidm-db commented on code in PR #49427:
URL: https://github.com/apache/spark/pull/49427#discussion_r1916442929
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala:
##########
@@ -185,5 +247,7 @@ case class SqlScriptingInterpreter(session: SparkSession) {
args,
isInternal = false,
context)
+
+ case _ => throw new UnsupportedOperationException(s"Unsupported
statement: $node")
Review Comment:
IIRC, the agreement in OSS Spark is to thrown internal error for all cases
when something is a bug. If this happens, I would consider it as a bug I think.
cc: @cloud-fan
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala:
##########
@@ -185,5 +247,7 @@ case class SqlScriptingInterpreter(session: SparkSession) {
args,
isInternal = false,
context)
+
+ case _ => throw new UnsupportedOperationException(s"Unsupported
statement: $node")
Review Comment:
IIRC, the agreement in OSS Spark is to thrown internal error for all cases
when something is a bug. If this happens, I would consider it as a bug I think.
cc: @cloud-fan to double check
##########
sql/core/src/main/scala/org/apache/spark/sql/scripting/SqlScriptingInterpreter.scala:
##########
@@ -185,5 +247,7 @@ case class SqlScriptingInterpreter(session: SparkSession) {
args,
isInternal = false,
context)
+
+ case _ => throw new UnsupportedOperationException(s"Unsupported
statement: $node")
Review Comment:
IIRC, the agreement in OSS Spark is to thrown internal error for all cases
when something is a bug. If this happens, I would consider it as a bug I think.
cc: @cloud-fan to double check exception type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
