Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23760 )
Change subject: IMPALA-14612: Add global metrics for admission state map size ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23760/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23760/3//COMMIT_MSG@16 PS3, Line 16: the removal l > Have you consider wrapping both the map and the gauge as a single object? I'm wondering if ShardedQueryMap is the best type for the admission_state_map_ variable. This type shards into 4 buckets each with their own lock. The map holds objects only for queries that have been admitted. Once the memory leak has been fixed, there will not be a lot of objects stored in this map. What if the map type was switched to std::unordered_map and a new std::shared_mutex was used to protect this map? Then, the map's Count() function could be called whenever the exclusive lock is taken to make changes to the map. -- To view, visit http://gerrit.cloudera.org:8080/23760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie803aabf8d91b6381c5d0d7534cd9c9fc2166a73 Gerrit-Change-Number: 23760 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 16 Dec 2025 20:29:54 +0000 Gerrit-HasComments: Yes
