Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23760 )
Change subject: IMPALA-14612: Add global metrics for admission state map size ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/23760/1/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/23760/1/be/src/scheduling/admission-control-service.cc@318 PS1, Line 318: AdmissionHeartbeatResponsePB* resp, kudu::rpc::RpcContext* rpc_context) { > Use another way to implement. I understand the concern about metric value getting out of sync with map size. I don't know that two second intervals to update the metric is the best approach. A lot can happen in AdmissionD in two seconds. Also, during quiet periods, there is work being done to repeatedly retrieve the map size even though we know it hasn't changed. http://gerrit.cloudera.org:8080/#/c/23760/3/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/23760/3/be/src/scheduling/admission-control-service.cc@98 PS3, Line 98: this Avoid using "this" as part of the Lambda context. Instead, use only the three variables needed by this lambda (last_map_size_update_ms_, cached_admission_map_size_, and last_map_size_update_ms_). http://gerrit.cloudera.org:8080/#/c/23760/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23760/1/tests/custom_cluster/test_admission_controller.py@2392 PS1, Line 2392: client2 = coord2.service.create_hs2_client() > Done Done http://gerrit.cloudera.org:8080/#/c/23760/1/tests/custom_cluster/test_admission_controller.py@2423 PS1, Line 2423: @SkipIfNotHdfsMinicluster.tuned_for_minicluster > Done Done -- To view, visit http://gerrit.cloudera.org:8080/23760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie803aabf8d91b6381c5d0d7534cd9c9fc2166a73 Gerrit-Change-Number: 23760 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 23:57:47 +0000 Gerrit-HasComments: Yes
