Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23760 )
Change subject: IMPALA-14612: Add global metrics for admission state map size ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/23760/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23760/3//COMMIT_MSG@16 PS3, Line 16: the removal l > Thanks for the suggestions. This solution looks good to me! http://gerrit.cloudera.org:8080/#/c/23760/6/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23760/6/tests/custom_cluster/test_admission_controller.py@2421 PS6, Line 2421: "admission-control-service.num-queries", 0) Please add an assert for the highwater mark metric. -- To view, visit http://gerrit.cloudera.org:8080/23760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie803aabf8d91b6381c5d0d7534cd9c9fc2166a73 Gerrit-Change-Number: 23760 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 18 Dec 2025 20:32:48 +0000 Gerrit-HasComments: Yes
