Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23760 )
Change subject: IMPALA-14612: Add global metrics for admission state map size ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23760/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23760/3//COMMIT_MSG@8 PS3, Line 8: : We need better observability for the admission state map to warn : about potential memory leaks. We have observed cases where admission : state entries were not released, causing memory leaks in admissiond. nit: Can you tell us a bit about the behavior of admission state map in commit message? When it should mutate its value? When is an entry put and removed? http://gerrit.cloudera.org:8080/#/c/23760/3//COMMIT_MSG@16 PS3, Line 16: FunctionGauge Why not use existing AtomicHighWaterMarkGauge? -- To view, visit http://gerrit.cloudera.org:8080/23760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie803aabf8d91b6381c5d0d7534cd9c9fc2166a73 Gerrit-Change-Number: 23760 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 16:48:47 +0000 Gerrit-HasComments: Yes
