Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23760 )
Change subject: IMPALA-14612: Add global metrics for admission state map size ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23760/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23760/3//COMMIT_MSG@16 PS3, Line 16: the removal l > I'm wondering if ShardedQueryMap is the best type for the admission_state_m Thanks for the suggestions. Wrapping the behavior is safer. I have modified GenericShardedQueryMap to accept an AtomicHighWaterMarkGauge*. Now, the Add() and Delete() automatically handle the metric increment and decrement. unordered_map seems good to consider, but since GenericShardedQueryMap is working well and correctly so far, this patch I prefer to leave it there to minimize regression risk -- To view, visit http://gerrit.cloudera.org:8080/23760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie803aabf8d91b6381c5d0d7534cd9c9fc2166a73 Gerrit-Change-Number: 23760 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 17 Dec 2025 01:46:41 +0000 Gerrit-HasComments: Yes
