Yida Wu has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/23760 )
Change subject: IMPALA-14612: Add global metrics for admission state map size ...................................................................... IMPALA-14612: Add global metrics for admission state map size We need better observability for the admission state map to warn about potential memory leaks. We have observed cases where admission state entries were not released, causing memory leaks in admissiond. Adds the metric admission-control-service.admission-state-map-size to track the number of active entries. Instead of tracking every add or remove operation on the map, this patch introduces a FunctionGauge to read the real-time map size. The callback function prevents excessive locking of the map by returning a cached size, refreshing it only after a specific update interval. Tests: Updated and passed test_admission_state_map_mem_leak to verify the metrics. Added a unit test for the newly added FunctionGauge. Change-Id: Ie803aabf8d91b6381c5d0d7534cd9c9fc2166a73 --- M be/src/scheduling/admission-control-service.cc M be/src/scheduling/admission-control-service.h M be/src/util/metrics-test.cc M be/src/util/metrics.h M common/thrift/metrics.json M tests/custom_cluster/test_admission_controller.py 6 files changed, 83 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/23760/3 -- To view, visit http://gerrit.cloudera.org:8080/23760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ie803aabf8d91b6381c5d0d7534cd9c9fc2166a73 Gerrit-Change-Number: 23760 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
