Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22065 )
Change subject: Improve error message in EE tests after crash ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22065/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22065/2//COMMIT_MSG@17 PS2, Line 17: An alternative would be to pass the tests in this case (instead : of failing it) but this may lead to all green test runs in the : rare case when Impala crashes between tests. > I had the same thought that the check should happen at the end of the test, >I don't see where this code will handle those situations. You mean this for the current patch, or the case when cluster health would be checked at the end of the test? The linked test sets expect_startup_fail=True, so setup_class() won't be called. The current patch only changes the exception where the original code would also throw an exception. -- To view, visit http://gerrit.cloudera.org:8080/22065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17cce8ccda85c9f5e4b1288e1708c8b84ea724f1 Gerrit-Change-Number: 22065 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2024 14:14:44 +0000 Gerrit-HasComments: Yes
