Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22065 )
Change subject: Improve error message in EE tests after crash ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22065/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22065/1//COMMIT_MSG@18 PS1, Line 18: of failing it) but this may lead to all green test runs in the > I don't understand this completely - do you mean this for the alternative p Is the concern here that we are going to get more test failures by raising this error? If only 1 impalad fails to start, tests can still pass. If so, what if this code attempts to restart the cluster before throwing an exception? -- To view, visit http://gerrit.cloudera.org:8080/22065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17cce8ccda85c9f5e4b1288e1708c8b84ea724f1 Gerrit-Change-Number: 22065 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 13 Nov 2024 19:02:06 +0000 Gerrit-HasComments: Yes
