Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22065 )
Change subject: Improve error message in EE tests after crash ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/22065/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22065/2//COMMIT_MSG@17 PS2, Line 17: An alternative would be to pass the tests in this case (instead : of failing it) but this may lead to all green test runs in the : rare case when Impala crashes between tests. > Yes, during jenkins runs the crash would be detected, but not when one loca There are a few tests that expect a crash and a minidump to be generated. For example: https://github.com/apache/impala/blob/1f35747ea3677bd004f8ed7b1cc94d6ef2f70c8e/tests/custom_cluster/test_workload_mgmt_init.py#L577-L593 I don't see where this code will handle those situations. http://gerrit.cloudera.org:8080/#/c/22065/2//COMMIT_MSG@17 PS2, Line 17: An alternative would be to pass the tests in this case (instead : of failing it) but this may lead to all green test runs in the : rare case when Impala crashes between tests. > What I tried to express in this paragraph is exactly why I didn't want to d I had the same thought that the check should happen at the end of the test, that way the test that failed would be the test where the Impalad crashed instead of the next test that ran after the crash. -- To view, visit http://gerrit.cloudera.org:8080/22065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17cce8ccda85c9f5e4b1288e1708c8b84ea724f1 Gerrit-Change-Number: 22065 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 14 Nov 2024 18:26:17 +0000 Gerrit-HasComments: Yes
