Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21663 )
Change subject: IMPALA-13126: Obtain table read lock in EP to process partitioned event ...................................................................... Patch Set 2: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21663/2/fe/src/main/java/org/apache/impala/catalog/Catalog.java File fe/src/main/java/org/apache/impala/catalog/Catalog.java: http://gerrit.cloudera.org:8080/#/c/21663/2/fe/src/main/java/org/apache/impala/catalog/Catalog.java@493 PS2, Line 493: org.apache.hadoop.hive.metastore.api.Partition msPart, boolean isEventProcessor) throws CatalogException { line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/21663/2/fe/src/main/java/org/apache/impala/catalog/Catalog.java@504 PS2, Line 504: return getHdfsPartition(table.getDb().getName(), table.getName(), partitionSpec, isEventProcessor); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/21663/2/fe/src/main/java/org/apache/impala/catalog/Catalog.java@532 PS2, Line 532: List<TPartitionKeyValue> partitionSpec, boolean isEventProcessor) throws CatalogException { line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21663/2/fe/src/main/java/org/apache/impala/catalog/Catalog.java@542 PS2, Line 542: ((HdfsTable) table).getPartitionFromThriftPartitionSpec(partitionSpec, isEventProcessor); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21663/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/21663/2/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4244 PS2, Line 4244: HdfsPartition hdfsPartition = getHdfsPartition(dbName, tableName, msPartition, true); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21663/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/21663/2/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1305 PS2, Line 1305: String messageStr = partitionEventObj == null ? "Skipping the event since the" + line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21663/2/tests/custom_cluster/test_concurrent_ddls.py File tests/custom_cluster/test_concurrent_ddls.py: http://gerrit.cloudera.org:8080/#/c/21663/2/tests/custom_cluster/test_concurrent_ddls.py@244 PS2, Line 244: flake8: E261 at least two spaces before inline comment -- To view, visit http://gerrit.cloudera.org:8080/21663 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26933f98556736f66df986f9440ebb64be395bc1 Gerrit-Change-Number: 21663 Gerrit-PatchSet: 2 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 14 Nov 2024 20:55:43 +0000 Gerrit-HasComments: Yes
