Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22065 )
Change subject: Improve error message in EE tests after crash ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22065/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22065/2//COMMIT_MSG@17 PS2, Line 17: An alternative would be to pass the tests in this case (instead : of failing it) but this may lead to all green test runs in the : rare case when Impala crashes between tests. > I might be wrong but I thought we fail the build if minidumps are detected: Yes, during jenkins runs the crash would be detected, but not when one locally runs some test suite. It would be nice to add some crash detection in that case too. -- To view, visit http://gerrit.cloudera.org:8080/22065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17cce8ccda85c9f5e4b1288e1708c8b84ea724f1 Gerrit-Change-Number: 22065 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 14 Nov 2024 16:24:39 +0000 Gerrit-HasComments: Yes
