Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22065 )
Change subject: Improve error message in EE tests after crash ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22065/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22065/1//COMMIT_MSG@18 PS1, Line 18: of failing it) but this may lead to all green test runs in the > Is the concern here that we are going to get more test failures by raising I meant it for the alternative. Some tests rely on running on 3 impalads. I can't remember which but I've seen failures when running only 1 impalad when with running 3 the test passed. I think it may be when asserting on memory consumption etc. in profiles. Can't we somehow stop the test runs altogether in this case? This would avoid many falsely failing tests but still indicate the run was not successful. -- To view, visit http://gerrit.cloudera.org:8080/22065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17cce8ccda85c9f5e4b1288e1708c8b84ea724f1 Gerrit-Change-Number: 22065 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 14 Nov 2024 10:58:43 +0000 Gerrit-HasComments: Yes
