Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190122092909.5341-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de -> patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de * [new tag] patchew/20190131210851.9842-1-richard.hender...@linaro.org -> patchew/20190131210851.9842-1-richard.hender...@linaro.org Switched to a new branch 'test' 8fbe349 target/riscv: Remaining rvc insn reuse 32 bit translators 24ac6df target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 a872fb0 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 b15e98a target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 8620f8c target/riscv: Convert @cs_2 insns to share translation functions 34fdff0 target/riscv: Remove decode_RV32_64G() 18fef41 target/riscv: Remove gen_system() 0c7096a target/riscv: Rename trans_arith to gen_arith 11b4396 target/riscv: Remove manual decoding of RV32/64M insn 03ea617 target/riscv: Remove shift and slt insn manual decoding b9d345c target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists f9f6281 target/riscv: Move gen_arith_imm() decoding into trans_* functions 28988be target/riscv: Remove manual decoding from gen_store() b227163 target/riscv: Remove manual decoding from gen_load() 2d9466d target/riscv: Remove manual decoding from gen_branch() 389dfb1 target/riscv: Remove gen_jalr() 015e21b target/riscv: Convert quadrant 2 of RVXC insns to decodetree f7599be target/riscv: Convert quadrant 1 of RVXC insns to decodetree b43b908 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 9def3a0 target/riscv: Convert RV priv insns to decodetree cb6a85c target/riscv: Convert RV64D insns to decodetree de12358 target/riscv: Convert RV32D insns to decodetree 3637746 target/riscv: Convert RV64F insns to decodetree f7f1cee target/riscv: Convert RV32F insns to decodetree ff48f82 target/riscv: Convert RV64A insns to decodetree 59216b4 target/riscv: Convert RV32A insns to decodetree ecd3e26 target/riscv: Convert RVXM insns to decodetree f925ddf target/riscv: Convert RVXI csr insns to decodetree 0521076 target/riscv: Convert RVXI fence insns to decodetree 96ef5df target/riscv: Convert RVXI arithmetic insns to decodetree 720d36f target/riscv: Convert RV64I load/store insns to decodetree 4ca2a53 target/riscv: Convert RV32I load/store insns to decodetree 797e17e target/riscv: Convert RVXI branch insns to decodetree 5fe471c target/riscv: Activate decodetree and implemnt LUI & AUIPC 2f6484f target/riscv: Move CPURISCVState pointer to DisasContext === OUTPUT BEGIN === 1/35 Checking commit 2f6484fc8b40 (target/riscv: Move CPURISCVState pointer to DisasContext) 2/35 Checking commit 5fe471c8d889 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1687: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 2/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/35 Checking commit 797e17e309d8 (target/riscv: Convert RVXI branch insns to decodetree) 4/35 Checking commit 4ca2a533ae0f (target/riscv: Convert RV32I load/store insns to decodetree) 5/35 Checking commit 720d36fcb482 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 5/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/35 Checking commit 96ef5df64035 (target/riscv: Convert RVXI arithmetic insns to decodetree) 7/35 Checking commit 052107679d38 (target/riscv: Convert RVXI fence insns to decodetree) 8/35 Checking commit f925ddff48df (target/riscv: Convert RVXI csr insns to decodetree) 9/35 Checking commit ecd3e263f4d3 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 145 lines checked Patch 9/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/35 Checking commit 59216b476599 (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 188 lines checked Patch 10/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/35 Checking commit ff48f827e32e (target/riscv: Convert RV64A insns to decodetree) 12/35 Checking commit f7f1cee6bd8e (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 397 lines checked Patch 12/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/35 Checking commit 36377467f850 (target/riscv: Convert RV64F insns to decodetree) 14/35 Checking commit de1235869bc2 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 353 lines checked Patch 14/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/35 Checking commit cb6a85c27a39 (target/riscv: Convert RV64D insns to decodetree) 16/35 Checking commit 9def3a0b2d95 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 16/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/35 Checking commit b43b9081a0f3 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #246: FILE: target/riscv/translate.c:983: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 227 lines checked Patch 17/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/35 Checking commit f7599be1fd21 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 19/35 Checking commit 015e21b27bf7 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 20/35 Checking commit 389dfb149423 (target/riscv: Remove gen_jalr()) 21/35 Checking commit 2d9466dce10a (target/riscv: Remove manual decoding from gen_branch()) 22/35 Checking commit b2271639923f (target/riscv: Remove manual decoding from gen_load()) 23/35 Checking commit 28988be5c3bc (target/riscv: Remove manual decoding from gen_store()) 24/35 Checking commit f9f628120c9c (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 25/35 Checking commit b9d345ca148a (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 26/35 Checking commit 03ea61736dc8 (target/riscv: Remove shift and slt insn manual decoding) 27/35 Checking commit 11b4396056a6 (target/riscv: Remove manual decoding of RV32/64M insn) 28/35 Checking commit 0c7096a8d646 (target/riscv: Rename trans_arith to gen_arith) 29/35 Checking commit 18fef4163596 (target/riscv: Remove gen_system()) 30/35 Checking commit 34fdff00d347 (target/riscv: Remove decode_RV32_64G()) 31/35 Checking commit 8620f8c0fe27 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:497: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 31/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/35 Checking commit b15e98a2cb7b (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 33/35 Checking commit a872fb08fd46 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 287 lines checked Patch 33/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/35 Checking commit 24ac6df1be53 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 35/35 Checking commit 8fbe34935f3c (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com