Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree Message-id: 20190122092909.5341-1-kbast...@mail.uni-paderborn.de Type: series === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de -> patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de * [new tag] patchew/20190131210851.9842-1-richard.hender...@linaro.org -> patchew/20190131210851.9842-1-richard.hender...@linaro.org Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone' Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc' Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers' Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF' Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe' Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios' Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware' Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode' Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios' Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa' Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios' Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot' Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot' Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex' Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3' Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3' Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb' Cloning into 'capstone'... Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf' Cloning into 'dtc'... Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536' Cloning into 'roms/QemuMacDrivers'... Submodule path 'roms/QemuMacDrivers': checked out 'd4e7d7ac663fcb55f1b93575445fcbca372f17a7' Cloning into 'roms/SLOF'... Submodule path 'roms/SLOF': checked out '9b7ab2fa020341dee8bf9df6c9cf40003e0136df' Cloning into 'roms/ipxe'... Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17' Cloning into 'roms/openbios'... Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b' Cloning into 'roms/openhackware'... Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5' Cloning into 'roms/qemu-palcode'... Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097' Cloning into 'roms/seabios'... Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307' Cloning into 'roms/seabios-hppa'... Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0' Cloning into 'roms/sgabios'... Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a' Cloning into 'roms/skiboot'... Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc' Cloning into 'roms/u-boot'... Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943' Cloning into 'roms/u-boot-sam460ex'... Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588' Cloning into 'tests/fp/berkeley-softfloat-3'... Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037' Cloning into 'tests/fp/berkeley-testfloat-3'... Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3' Cloning into 'ui/keycodemapdb'... Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce' Switched to a new branch 'test' ed5d29b target/riscv: Remaining rvc insn reuse 32 bit translators b54031a target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 9b963a1 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 eb5cc3d target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns f31df48 target/riscv: Convert @cs_2 insns to share translation functions 8499159 target/riscv: Remove decode_RV32_64G() 3ac75b0 target/riscv: Remove gen_system() 28b7019 target/riscv: Rename trans_arith to gen_arith c69cef8 target/riscv: Remove manual decoding of RV32/64M insn 0fee6c7 target/riscv: Remove shift and slt insn manual decoding 3e8a05f target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 2805954 target/riscv: Move gen_arith_imm() decoding into trans_* functions 4ca0f72 target/riscv: Remove manual decoding from gen_store() bba5eb0 target/riscv: Remove manual decoding from gen_load() 2382078 target/riscv: Remove manual decoding from gen_branch() 51720e7 target/riscv: Remove gen_jalr() 76fe773 target/riscv: Convert quadrant 2 of RVXC insns to decodetree cbdbfe4 target/riscv: Convert quadrant 1 of RVXC insns to decodetree a845ad9 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 4757f88 target/riscv: Convert RV priv insns to decodetree a45dc64 target/riscv: Convert RV64D insns to decodetree 81d433a target/riscv: Convert RV32D insns to decodetree a2817b8 target/riscv: Convert RV64F insns to decodetree a4b3aa5 target/riscv: Convert RV32F insns to decodetree f571c73 target/riscv: Convert RV64A insns to decodetree 3099ed9 target/riscv: Convert RV32A insns to decodetree e5cff57 target/riscv: Convert RVXM insns to decodetree 3e87961 target/riscv: Convert RVXI csr insns to decodetree a9ff2a1 target/riscv: Convert RVXI fence insns to decodetree fc1d4e4 target/riscv: Convert RVXI arithmetic insns to decodetree 40eb746 target/riscv: Convert RV64I load/store insns to decodetree 18be721 target/riscv: Convert RV32I load/store insns to decodetree 3a4a0f2 target/riscv: Convert RVXI branch insns to decodetree b44b4cc target/riscv: Activate decodetree and implemnt LUI & AUIPC 257d7a3 target/riscv: Move CPURISCVState pointer to DisasContext === OUTPUT BEGIN === 1/35 Checking commit 257d7a3545e4 (target/riscv: Move CPURISCVState pointer to DisasContext) 2/35 Checking commit b44b4cc80078 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1687: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 2/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/35 Checking commit 3a4a0f26abd1 (target/riscv: Convert RVXI branch insns to decodetree) 4/35 Checking commit 18be72113172 (target/riscv: Convert RV32I load/store insns to decodetree) 5/35 Checking commit 40eb746234ae (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 5/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/35 Checking commit fc1d4e4b6fdc (target/riscv: Convert RVXI arithmetic insns to decodetree) 7/35 Checking commit a9ff2a19cbb4 (target/riscv: Convert RVXI fence insns to decodetree) 8/35 Checking commit 3e8796163e96 (target/riscv: Convert RVXI csr insns to decodetree) 9/35 Checking commit e5cff571cf52 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 145 lines checked Patch 9/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/35 Checking commit 3099ed9f2afe (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 188 lines checked Patch 10/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/35 Checking commit f571c731a1cf (target/riscv: Convert RV64A insns to decodetree) 12/35 Checking commit a4b3aa51137d (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 397 lines checked Patch 12/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/35 Checking commit a2817b828ef7 (target/riscv: Convert RV64F insns to decodetree) 14/35 Checking commit 81d433a3555c (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 353 lines checked Patch 14/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/35 Checking commit a45dc64b147c (target/riscv: Convert RV64D insns to decodetree) 16/35 Checking commit 4757f887d39f (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 16/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/35 Checking commit a845ad916796 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #246: FILE: target/riscv/translate.c:983: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 227 lines checked Patch 17/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/35 Checking commit cbdbfe4ce623 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 19/35 Checking commit 76fe77374a60 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 20/35 Checking commit 51720e787149 (target/riscv: Remove gen_jalr()) 21/35 Checking commit 2382078c37bb (target/riscv: Remove manual decoding from gen_branch()) 22/35 Checking commit bba5eb03d70f (target/riscv: Remove manual decoding from gen_load()) 23/35 Checking commit 4ca0f7208f9f (target/riscv: Remove manual decoding from gen_store()) 24/35 Checking commit 2805954f69ea (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 25/35 Checking commit 3e8a05f65cb5 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 26/35 Checking commit 0fee6c777814 (target/riscv: Remove shift and slt insn manual decoding) 27/35 Checking commit c69cef8906b7 (target/riscv: Remove manual decoding of RV32/64M insn) 28/35 Checking commit 28b70192feb3 (target/riscv: Rename trans_arith to gen_arith) 29/35 Checking commit 3ac75b04e92d (target/riscv: Remove gen_system()) 30/35 Checking commit 84991598cd17 (target/riscv: Remove decode_RV32_64G()) 31/35 Checking commit f31df482709c (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:497: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 31/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/35 Checking commit eb5cc3d89f71 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 33/35 Checking commit 9b963a191d7b (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 287 lines checked Patch 33/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/35 Checking commit b54031a6e1c5 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 35/35 Checking commit ed5d29b4e2b6 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
