Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree Type: series Message-id: 20190122092909.5341-1-kbast...@mail.uni-paderborn.de === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de -> patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' 291fb3378a target/riscv: Remaining rvc insn reuse 32 bit translators f234c9a301 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 16680b13d8 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 8c27631fd4 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns d2bb2de935 target/riscv: Convert @cs_2 insns to share translation functions 24f04339fe target/riscv: Remove decode_RV32_64G() 8e284b2972 target/riscv: Remove gen_system() 7fdd5f104c target/riscv: Rename trans_arith to gen_arith 696cd56967 target/riscv: Remove manual decoding of RV32/64M insn 81c0dbfad9 target/riscv: Remove shift and slt insn manual decoding 69947ae047 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists b162444c18 target/riscv: Move gen_arith_imm() decoding into trans_* functions 9d189f830c target/riscv: Remove manual decoding from gen_store() b9e24ac0d5 target/riscv: Remove manual decoding from gen_load() 543c238dc7 target/riscv: Remove manual decoding from gen_branch() 1ecefc4283 target/riscv: Remove gen_jalr() 4251a010bd target/riscv: Convert quadrant 2 of RVXC insns to decodetree 3a0627ae71 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 135f107593 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 8833d537b5 target/riscv: Convert RV priv insns to decodetree 28b613a932 target/riscv: Convert RV64D insns to decodetree 02b797edd5 target/riscv: Convert RV32D insns to decodetree 27cc348b3b target/riscv: Convert RV64F insns to decodetree b0857e0983 target/riscv: Convert RV32F insns to decodetree b578a96842 target/riscv: Convert RV64A insns to decodetree 26ca8f5631 target/riscv: Convert RV32A insns to decodetree 0ef195feef target/riscv: Convert RVXM insns to decodetree d22f711d7d target/riscv: Convert RVXI csr insns to decodetree 34de7f7504 target/riscv: Convert RVXI fence insns to decodetree da5403e39d target/riscv: Convert RVXI arithmetic insns to decodetree f8d0548e2d target/riscv: Convert RV64I load/store insns to decodetree 7f40538802 target/riscv: Convert RV32I load/store insns to decodetree d5b10e4501 target/riscv: Convert RVXI branch insns to decodetree 26e2990ada target/riscv: Activate decodetree and implemnt LUI & AUIPC 2d78010a7d target/riscv: Move CPURISCVState pointer to DisasContext === OUTPUT BEGIN === 1/35 Checking commit 2d78010a7d7b (target/riscv: Move CPURISCVState pointer to DisasContext) 2/35 Checking commit 26e2990adad9 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1687: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 2/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/35 Checking commit d5b10e450153 (target/riscv: Convert RVXI branch insns to decodetree) 4/35 Checking commit 7f40538802f9 (target/riscv: Convert RV32I load/store insns to decodetree) 5/35 Checking commit f8d0548e2da9 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 5/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/35 Checking commit da5403e39dfc (target/riscv: Convert RVXI arithmetic insns to decodetree) 7/35 Checking commit 34de7f750472 (target/riscv: Convert RVXI fence insns to decodetree) 8/35 Checking commit d22f711d7ddb (target/riscv: Convert RVXI csr insns to decodetree) 9/35 Checking commit 0ef195feef49 (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 145 lines checked Patch 9/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/35 Checking commit 26ca8f56316d (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 188 lines checked Patch 10/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/35 Checking commit b578a9684221 (target/riscv: Convert RV64A insns to decodetree) 12/35 Checking commit b0857e0983f9 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 397 lines checked Patch 12/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/35 Checking commit 27cc348b3b41 (target/riscv: Convert RV64F insns to decodetree) 14/35 Checking commit 02b797edd5e8 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 353 lines checked Patch 14/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/35 Checking commit 28b613a9323b (target/riscv: Convert RV64D insns to decodetree) 16/35 Checking commit 8833d537b599 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 16/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/35 Checking commit 135f10759377 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #246: FILE: target/riscv/translate.c:983: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 227 lines checked Patch 17/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/35 Checking commit 3a0627ae7139 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 19/35 Checking commit 4251a010bd40 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 20/35 Checking commit 1ecefc428332 (target/riscv: Remove gen_jalr()) 21/35 Checking commit 543c238dc767 (target/riscv: Remove manual decoding from gen_branch()) 22/35 Checking commit b9e24ac0d566 (target/riscv: Remove manual decoding from gen_load()) 23/35 Checking commit 9d189f830c77 (target/riscv: Remove manual decoding from gen_store()) 24/35 Checking commit b162444c1849 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 25/35 Checking commit 69947ae04778 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 26/35 Checking commit 81c0dbfad9c7 (target/riscv: Remove shift and slt insn manual decoding) 27/35 Checking commit 696cd5696710 (target/riscv: Remove manual decoding of RV32/64M insn) 28/35 Checking commit 7fdd5f104c9d (target/riscv: Rename trans_arith to gen_arith) 29/35 Checking commit 8e284b2972e0 (target/riscv: Remove gen_system()) 30/35 Checking commit 24f04339fe94 (target/riscv: Remove decode_RV32_64G()) 31/35 Checking commit d2bb2de93587 (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:497: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 31/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/35 Checking commit 8c27631fd427 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 33/35 Checking commit 16680b13d8ee (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 287 lines checked Patch 33/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/35 Checking commit f234c9a30159 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 35/35 Checking commit 291fb3378aab (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com