Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree Type: series Message-id: 20190122092909.5341-1-kbast...@mail.uni-paderborn.de === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu aefcd28366..e8977901b7 master -> master t [tag update] patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de -> patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de Switched to a new branch 'test' 84d9232271 target/riscv: Remaining rvc insn reuse 32 bit translators d914ca8ad6 target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 d91d36a5a5 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 96a7dd7cc4 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 4be75db113 target/riscv: Convert @cs_2 insns to share translation functions 5df6fa908b target/riscv: Remove decode_RV32_64G() 9e15d220cb target/riscv: Remove gen_system() 569b624066 target/riscv: Rename trans_arith to gen_arith ab8fe35848 target/riscv: Remove manual decoding of RV32/64M insn 35c8b7cf65 target/riscv: Remove shift and slt insn manual decoding aa1fcbc0b2 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists 09af9d97eb target/riscv: Move gen_arith_imm() decoding into trans_* functions 2b6c72f3da target/riscv: Remove manual decoding from gen_store() 1d3a7b5cb7 target/riscv: Remove manual decoding from gen_load() 0551b57210 target/riscv: Remove manual decoding from gen_branch() 129eb0e041 target/riscv: Remove gen_jalr() 65a653d84d target/riscv: Convert quadrant 2 of RVXC insns to decodetree faca63ff69 target/riscv: Convert quadrant 1 of RVXC insns to decodetree 0e9ac5bbcb target/riscv: Convert quadrant 0 of RVXC insns to decodetree 8871e9f09a target/riscv: Convert RV priv insns to decodetree 4ffcac38e7 target/riscv: Convert RV64D insns to decodetree 8b13dafd4a target/riscv: Convert RV32D insns to decodetree f59e9b8655 target/riscv: Convert RV64F insns to decodetree 8cd874a0eb target/riscv: Convert RV32F insns to decodetree 4f9f53aa9e target/riscv: Convert RV64A insns to decodetree 17aee59b02 target/riscv: Convert RV32A insns to decodetree e93a947b94 target/riscv: Convert RVXM insns to decodetree 87454d7d1d target/riscv: Convert RVXI csr insns to decodetree 11f83510fd target/riscv: Convert RVXI fence insns to decodetree 40bf83abf8 target/riscv: Convert RVXI arithmetic insns to decodetree 6f109f635b target/riscv: Convert RV64I load/store insns to decodetree 1bdc022b7c target/riscv: Convert RV32I load/store insns to decodetree ad3f70396f target/riscv: Convert RVXI branch insns to decodetree 693a52f261 target/riscv: Activate decodetree and implemnt LUI & AUIPC b098fdaf40 target/riscv: Move CPURISCVState pointer to DisasContext === OUTPUT BEGIN === 1/35 Checking commit b098fdaf40da (target/riscv: Move CPURISCVState pointer to DisasContext) 2/35 Checking commit 693a52f261fd (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1687: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 2/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/35 Checking commit ad3f70396f2e (target/riscv: Convert RVXI branch insns to decodetree) 4/35 Checking commit 1bdc022b7ca3 (target/riscv: Convert RV32I load/store insns to decodetree) 5/35 Checking commit 6f109f635b03 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 5/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/35 Checking commit 40bf83abf814 (target/riscv: Convert RVXI arithmetic insns to decodetree) 7/35 Checking commit 11f83510fd16 (target/riscv: Convert RVXI fence insns to decodetree) 8/35 Checking commit 87454d7d1d12 (target/riscv: Convert RVXI csr insns to decodetree) 9/35 Checking commit e93a947b945f (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 145 lines checked Patch 9/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/35 Checking commit 17aee59b02db (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 188 lines checked Patch 10/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/35 Checking commit 4f9f53aa9e45 (target/riscv: Convert RV64A insns to decodetree) 12/35 Checking commit 8cd874a0eb9b (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 397 lines checked Patch 12/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/35 Checking commit f59e9b865598 (target/riscv: Convert RV64F insns to decodetree) 14/35 Checking commit 8b13dafd4acf (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 353 lines checked Patch 14/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/35 Checking commit 4ffcac38e78f (target/riscv: Convert RV64D insns to decodetree) 16/35 Checking commit 8871e9f09a5f (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 16/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/35 Checking commit 0e9ac5bbcbe0 (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #246: FILE: target/riscv/translate.c:983: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 227 lines checked Patch 17/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/35 Checking commit faca63ff6943 (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 19/35 Checking commit 65a653d84db9 (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 20/35 Checking commit 129eb0e041ee (target/riscv: Remove gen_jalr()) 21/35 Checking commit 0551b5721024 (target/riscv: Remove manual decoding from gen_branch()) 22/35 Checking commit 1d3a7b5cb775 (target/riscv: Remove manual decoding from gen_load()) 23/35 Checking commit 2b6c72f3dae3 (target/riscv: Remove manual decoding from gen_store()) 24/35 Checking commit 09af9d97ebf5 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 25/35 Checking commit aa1fcbc0b22f (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 26/35 Checking commit 35c8b7cf6516 (target/riscv: Remove shift and slt insn manual decoding) 27/35 Checking commit ab8fe35848eb (target/riscv: Remove manual decoding of RV32/64M insn) 28/35 Checking commit 569b6240661a (target/riscv: Rename trans_arith to gen_arith) 29/35 Checking commit 9e15d220cb1e (target/riscv: Remove gen_system()) 30/35 Checking commit 5df6fa908b20 (target/riscv: Remove decode_RV32_64G()) 31/35 Checking commit 4be75db1131a (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:497: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 31/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/35 Checking commit 96a7dd7cc432 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 33/35 Checking commit d91d36a5a5b1 (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 287 lines checked Patch 33/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/35 Checking commit d914ca8ad66d (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 35/35 Checking commit 84d923227191 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
