Patchew URL: https://patchew.org/QEMU/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20190122092909.5341-1-kbast...@mail.uni-paderborn.de Subject: [Qemu-devel] [PATCH v5 00/35] target/riscv: Convert to decodetree === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de -> patchew/20190122092909.5341-1-kbast...@mail.uni-paderborn.de * [new tag] patchew/20190131211931.16216-1-sv...@stackframe.org -> patchew/20190131211931.16216-1-sv...@stackframe.org Switched to a new branch 'test' 9e8165d target/riscv: Remaining rvc insn reuse 32 bit translators e66c95c target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64 efb9740 target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64 3c31768 target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns 795b478 target/riscv: Convert @cs_2 insns to share translation functions 110406e target/riscv: Remove decode_RV32_64G() 976eb72 target/riscv: Remove gen_system() 0edf15c target/riscv: Rename trans_arith to gen_arith dfa6dc2 target/riscv: Remove manual decoding of RV32/64M insn 5a6623c target/riscv: Remove shift and slt insn manual decoding 42aa254 target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists f6ead4a target/riscv: Move gen_arith_imm() decoding into trans_* functions 132f8da target/riscv: Remove manual decoding from gen_store() 2e18729 target/riscv: Remove manual decoding from gen_load() 308b594 target/riscv: Remove manual decoding from gen_branch() 12f3dae target/riscv: Remove gen_jalr() 663d608 target/riscv: Convert quadrant 2 of RVXC insns to decodetree f689ec9 target/riscv: Convert quadrant 1 of RVXC insns to decodetree baba3b6 target/riscv: Convert quadrant 0 of RVXC insns to decodetree 222b932 target/riscv: Convert RV priv insns to decodetree 57d7252 target/riscv: Convert RV64D insns to decodetree 85126a6 target/riscv: Convert RV32D insns to decodetree 4b1f8c6 target/riscv: Convert RV64F insns to decodetree ca3cfe3 target/riscv: Convert RV32F insns to decodetree 70fd254 target/riscv: Convert RV64A insns to decodetree d05a7c9 target/riscv: Convert RV32A insns to decodetree f56b79a target/riscv: Convert RVXM insns to decodetree f5805d1 target/riscv: Convert RVXI csr insns to decodetree 0d45dd0 target/riscv: Convert RVXI fence insns to decodetree 197e9af target/riscv: Convert RVXI arithmetic insns to decodetree f4195b8 target/riscv: Convert RV64I load/store insns to decodetree c44be19 target/riscv: Convert RV32I load/store insns to decodetree 944c287 target/riscv: Convert RVXI branch insns to decodetree 2b11f0f target/riscv: Activate decodetree and implemnt LUI & AUIPC a377eaf target/riscv: Move CPURISCVState pointer to DisasContext === OUTPUT BEGIN === 1/35 Checking commit a377eafc5405 (target/riscv: Move CPURISCVState pointer to DisasContext) 2/35 Checking commit 2b11f0fa7dd5 (target/riscv: Activate decodetree and implemnt LUI & AUIPC) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #34: new file mode 100644 ERROR: externs should be avoided in .c files #125: FILE: target/riscv/translate.c:1687: +bool decode_insn32(DisasContext *ctx, uint32_t insn); total: 1 errors, 1 warnings, 125 lines checked Patch 2/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/35 Checking commit 944c2876b315 (target/riscv: Convert RVXI branch insns to decodetree) 4/35 Checking commit c44be19b1c8f (target/riscv: Convert RV32I load/store insns to decodetree) 5/35 Checking commit f4195b886030 (target/riscv: Convert RV64I load/store insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #39: new file mode 100644 total: 0 errors, 1 warnings, 76 lines checked Patch 5/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/35 Checking commit 197e9af1264b (target/riscv: Convert RVXI arithmetic insns to decodetree) 7/35 Checking commit 0d45dd0abfc6 (target/riscv: Convert RVXI fence insns to decodetree) 8/35 Checking commit f5805d1ea703 (target/riscv: Convert RVXI csr insns to decodetree) 9/35 Checking commit f56b79ac87ee (target/riscv: Convert RVXM insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #48: new file mode 100644 total: 0 errors, 1 warnings, 145 lines checked Patch 9/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/35 Checking commit d05a7c91186f (target/riscv: Convert RV32A insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #54: new file mode 100644 total: 0 errors, 1 warnings, 188 lines checked Patch 10/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 11/35 Checking commit 70fd2547e6cf (target/riscv: Convert RV64A insns to decodetree) 12/35 Checking commit ca3cfe3dd932 (target/riscv: Convert RV32F insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #78: new file mode 100644 total: 0 errors, 1 warnings, 397 lines checked Patch 12/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/35 Checking commit 4b1f8c614b02 (target/riscv: Convert RV64F insns to decodetree) 14/35 Checking commit 85126a61bc34 (target/riscv: Convert RV32D insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 353 lines checked Patch 14/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 15/35 Checking commit 57d72521333c (target/riscv: Convert RV64D insns to decodetree) 16/35 Checking commit 222b932a1cf7 (target/riscv: Convert RV priv insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #41: new file mode 100644 total: 0 errors, 1 warnings, 214 lines checked Patch 16/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 17/35 Checking commit baba3b6b997c (target/riscv: Convert quadrant 0 of RVXC insns to decodetree) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #31: new file mode 100644 ERROR: externs should be avoided in .c files #246: FILE: target/riscv/translate.c:983: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 227 lines checked Patch 17/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 18/35 Checking commit f689ec99ed0e (target/riscv: Convert quadrant 1 of RVXC insns to decodetree) 19/35 Checking commit 663d608c7ebd (target/riscv: Convert quadrant 2 of RVXC insns to decodetree) 20/35 Checking commit 12f3dae1bfb8 (target/riscv: Remove gen_jalr()) 21/35 Checking commit 308b594c3adb (target/riscv: Remove manual decoding from gen_branch()) 22/35 Checking commit 2e18729d253e (target/riscv: Remove manual decoding from gen_load()) 23/35 Checking commit 132f8da29f26 (target/riscv: Remove manual decoding from gen_store()) 24/35 Checking commit f6ead4a8ee53 (target/riscv: Move gen_arith_imm() decoding into trans_* functions) 25/35 Checking commit 42aa2541a436 (target/riscv: make ADD/SUB/OR/XOR/AND insn use arg lists) 26/35 Checking commit 5a6623cc6dab (target/riscv: Remove shift and slt insn manual decoding) 27/35 Checking commit dfa6dc21c3ce (target/riscv: Remove manual decoding of RV32/64M insn) 28/35 Checking commit 0edf15c5d878 (target/riscv: Rename trans_arith to gen_arith) 29/35 Checking commit 976eb72944d8 (target/riscv: Remove gen_system()) 30/35 Checking commit 110406e2710f (target/riscv: Remove decode_RV32_64G()) 31/35 Checking commit 795b478c4c7f (target/riscv: Convert @cs_2 insns to share translation functions) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 ERROR: externs should be avoided in .c files #182: FILE: target/riscv/translate.c:497: +bool decode_insn16(DisasContext *ctx, uint16_t insn); total: 1 errors, 1 warnings, 164 lines checked Patch 31/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 32/35 Checking commit 3c31768d8171 (target/riscv: Convert @cl_d, @cl_w, @cs_d, @cs_w insns) 33/35 Checking commit efb9740ab17e (target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 287 lines checked Patch 33/35 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/35 Checking commit e66c95c9bca8 (target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64) 35/35 Checking commit 9e8165dd9406 (target/riscv: Remaining rvc insn reuse 32 bit translators) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190122092909.5341-1-kbast...@mail.uni-paderborn.de/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com