EnxDev commented on code in PR #33256:
URL: https://github.com/apache/superset/pull/33256#discussion_r2064116115
##########
superset-frontend/src/explore/components/controls/AnnotationLayerControl/index.tsx:
##########
@@ -193,7 +193,7 @@ class AnnotationLayerControl extends PureComponent<Props,
PopoverState> {
return (
<InfoTooltipWithTrigger
label="validation-errors"
- bsStyle="danger"
+ iconsStyle={{ color: theme.colorError }}
Review Comment:
According to the philosophy that was there before, with the bsStyle prop you
could decide the color, which was a CSS class, and with the icon prop you chose
the icon you wanted to use.
The component is also designed to work without the icon.
I had also thought about using only the AntD component, because this one
seemed like just a wrapper, but I didn’t want to do too much rework.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
