EnxDev commented on code in PR #33256:
URL: https://github.com/apache/superset/pull/33256#discussion_r2064056364
##########
superset-frontend/src/explore/components/controls/AnnotationLayerControl/index.tsx:
##########
@@ -193,7 +193,7 @@ class AnnotationLayerControl extends PureComponent<Props,
PopoverState> {
return (
<InfoTooltipWithTrigger
label="validation-errors"
- bsStyle="danger"
+ iconsStyle={{ color: theme.colorError }}
Review Comment:
I agree, I will provide three types:
1. base -> with grayscale color
2. warning -> with warning color
3. error -> with error color
I will allow the selection from three icons:
1. info circle
2. exclamation circle
3. exclamation triangle
I will add sizes for the icon sizes:
'xs' | 's' | 'm' | 'l' | 'xl' | 'xxl'
Any other suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
