geido commented on code in PR #33256:
URL: https://github.com/apache/superset/pull/33256#discussion_r2064092937
##########
superset-frontend/src/explore/components/controls/DndColumnSelectControl/Option.tsx:
##########
@@ -72,9 +72,13 @@ export default function Option({
<Label data-test="control-label">{children}</Label>
{(!!datasourceWarningMessage || isExtra) && (
<StyledInfoTooltipWithTrigger
- icon="exclamation-triangle"
+ icon={
Review Comment:
I think colors should always be the same based on the type "info",
"warning", "error". Font sizes might be different if you think you want to give
that option and we can standardize them too with 'xs' | 's' | 'm' | 'l' | 'xl'
| 'xxl' as you suggested above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
