EnxDev commented on code in PR #33256:
URL: https://github.com/apache/superset/pull/33256#discussion_r2065981930
##########
superset-frontend/src/explore/components/controls/AnnotationLayerControl/index.tsx:
##########
@@ -193,7 +193,7 @@ class AnnotationLayerControl extends PureComponent<Props,
PopoverState> {
return (
<InfoTooltipWithTrigger
label="validation-errors"
- bsStyle="danger"
+ iconsStyle={{ color: theme.colorError }}
Review Comment:
I have verified that, in this case, there wasn’t a clear standard being
followed, so @kasiazjc and I defined one together (see the PR description) and
I updated the purpose of this PR accordingly.
In SqlLab, `InfoTooltipWithTrigger` was being used from the
`@superset-ui/chart-controls` package in two instances. I replaced it with the
`IconTooltip` component.
I applied the defined standard to the pages where the
`InfoTooltipWithTrigger` component was being used.
For now, I’ve decided to keep the `InfoTooltipWithTrigger` component in the
`@superset-ui/chart-controls` package to avoid an additional refactor.
We can revisit this later, perhaps when the components are fully moved into
the shared package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
