geido commented on code in PR #33256:
URL: https://github.com/apache/superset/pull/33256#discussion_r2064151353
##########
superset-frontend/src/explore/components/controls/AnnotationLayerControl/index.tsx:
##########
@@ -193,7 +193,7 @@ class AnnotationLayerControl extends PureComponent<Props,
PopoverState> {
return (
<InfoTooltipWithTrigger
label="validation-errors"
- bsStyle="danger"
+ iconsStyle={{ color: theme.colorError }}
Review Comment:
> yellow exclamation circle and a yellow exclamation triangle
Mhhh this seems like it should not be the case. Maybe it was wrong
implementation decision. I'll leave to you to decide the level of
standardization based on what we have in the codebase / what we can reasonably
refactor. Thanks
##########
superset-frontend/src/explore/components/controls/AnnotationLayerControl/index.tsx:
##########
@@ -193,7 +193,7 @@ class AnnotationLayerControl extends PureComponent<Props,
PopoverState> {
return (
<InfoTooltipWithTrigger
label="validation-errors"
- bsStyle="danger"
+ iconsStyle={{ color: theme.colorError }}
Review Comment:
> yellow exclamation circle and a yellow exclamation triangle
Mhhh this seems like it should not be the case. Maybe it was wrong
implementation decision. I'll leave to you to decide the level of
standardization based on what we have in the codebase / what we can reasonably
refactor. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
