EnxDev opened a new pull request, #33256: URL: https://github.com/apache/superset/pull/33256
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> ### β¨ Whatβs changed - Replaced old FontAwesome (fa) icons with modern Ant Design 5 (antd5) icons inside InfoTooltipWithTrigger π₯ - Updated icon styling to use inline styles (color, fontSize only for this component) based on the AntD theme tokens π¨ - Removed unused bsStyle prop (no longer needed, we use theme tokens now)π§Ή - Tests updated to reflect the changes π ### π Why - To modernize components and remove deprecated FontAwesome usage - To align with the latest design system based on AntD 5 icons (This can be considered a continuation of [#32112](https://github.com/apache/superset/pull/32112)) - To ensure future compatibility and consistent theming ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> - Before  - After  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - All tests should pass - No visual regressions expected β icons still match old behavior but now using AntD 5. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
