On Thu, 29 Oct 2026 14:06:23 GMT, Volkan Yazici <[email protected]> wrote:
>> Fix port comparison in `java.net.URI::compareTo` and increase the test >> coverage. >> >> `open/test/jdk/java/net/URI/Test.java` is improved in following aspects: >> >> - Old `gt(u, v)` was delegating to `lt(v, u)`. This left `u.compareTo(v) > >> 0` path unchecked. >> - `eqHashCompUni(u, v)` is introduced to verify all `equals()`, >> `hashCode()`, `compareTo()` contracts. >> - `eqHashCompBid(u, v)` is introduced to verify `eqHashCompUni(u, v)` >> bidirectionally. >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Volkan Yazici has updated the pull request incrementally with one additional > commit since the last revision: > > Add xeq/xlt/xgt convenience methods test/jdk/java/net/URI/Test.java line 1593: > 1591: try { > 1592: Object o = oi.readObject(); > 1593: xeq(u, o); Suggestion: xeq(u, (URI)o); We need to assert that the object returned by readObject() is a URI. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33232#discussion_r4416517212
