> Fix port comparison in `java.net.URI::compareTo` and increase the test 
> coverage.
> 
> `open/test/jdk/java/net/URI/Test.java` is improved in following aspects:
> 
> - Old `gt(u, v)` was delegating to `lt(v, u)`. This left `u.compareTo(v) > 0` 
> path unchecked.
> - `eqHashCompUni(u, v)` is introduced to verify all `equals()`, `hashCode()`, 
> `compareTo()` contracts.
> - `eqHashCompBid(u, v)` is introduced to verify `eqHashCompUni(u, v)` 
> bidirectionally.
> 
> ---------
> - [X] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Volkan Yazici has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains 10 additional commits 
since the last revision:

 - Merge remote-tracking branch 'upstream/master' into uriCmp
 - Add explicit type checks to `serial(URI)`
 - Add xeq/xlt/xgt convenience methods
 - Switch from `String` to `char` for the relation representation
 - Remove unused `eq0()`
 - Rename `eqHashCompBid()` to `eqHashCompBidi()`
 - Remove `!=` relation
 - Fix `URI`
 - Increase test coverage
 - Implement bidirectional equals-hashCode-compareTo checks

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/33232/files
  - new: https://git.openjdk.org/jdk/pull/33232/files/7249669e..c34605e5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=33232&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33232&range=03-04

  Stats: 96029 lines in 2061 files changed: 59653 ins; 25089 del; 11287 mod
  Patch: https://git.openjdk.org/jdk/pull/33232.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/33232/head:pull/33232

PR: https://git.openjdk.org/jdk/pull/33232

Reply via email to