On Thu, 29 Oct 2026 18:46:17 GMT, Daniel Fuchs <[email protected]> wrote:
>> Volkan Yazici has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add xeq/xlt/xgt convenience methods
>
> test/jdk/java/net/URI/Test.java line 1593:
>
>> 1591: try {
>> 1592: Object o = oi.readObject();
>> 1593: xeq(u, o);
>
> Suggestion:
>
> xeq(u, (URI)o);
>
> We need to assert that the object returned by readObject() is a URI.
>
> Alternatively, you could also assert that `URI.class.isInstance(o)` before
> calling `xeq`
Switched the type of `o` from `Object` to `URI` in 7249669eba1.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33232#discussion_r4421935396
