On Tue, 6 Oct 2026 19:25:33 GMT, Volkan Yazici <[email protected]> wrote:
> Fix port comparison in `java.net.URI::compareTo` and increase the test > coverage. > > `open/test/jdk/java/net/URI/Test.java` is improved in following aspects: > > - Old `gt(u, v)` was delegating to `lt(v, u)`. This left `u.compareTo(v) > 0` > path unchecked. > - `eqHashCompUni(u, v)` is introduced to verify all `equals()`, `hashCode()`, > `compareTo()` contracts. > - `eqHashCompBid(u, v)` is introduced to verify `eqHashCompUni(u, v)` > bidirectionally. > > --------- > - [X] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). test/jdk/java/net/URI/Test.java line 1500: > 1498: URI t = new URI("http://example.com/%5bsegment%5d";); > 1499: eq(o, o); > 1500: lt(o, r); My preference would be to retain the `lt`, `gt`, `eq` method names because it's much more clearer to understand what these tests are doing at call sites, like here. In the implementations of `lt`, `gt`, `eq` etc... you could then just call the `eqHashCompBidi` method. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33232#discussion_r4376090286
