On Mon, 26 Oct 2026 15:33:38 GMT, Volkan Yazici <[email protected]> wrote:
>> Fix port comparison in `java.net.URI::compareTo` and increase the test >> coverage. >> >> `open/test/jdk/java/net/URI/Test.java` is improved in following aspects: >> >> - Old `gt(u, v)` was delegating to `lt(v, u)`. This left `u.compareTo(v) > >> 0` path unchecked. >> - `eqHashCompUni(u, v)` is introduced to verify all `equals()`, >> `hashCode()`, `compareTo()` contracts. >> - `eqHashCompBid(u, v)` is introduced to verify `eqHashCompUni(u, v)` >> bidirectionally. >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Volkan Yazici has updated the pull request incrementally with four additional > commits since the last revision: > > - Switch from `String` to `char` for the relation representation > - Remove unused `eq0()` > - Rename `eqHashCompBid()` to `eqHashCompBidi()` > - Remove `!=` relation Changing the comparison expectation to char instead of String helps eliminating suspicion about possible misuse with "<=" or ">=" - which are now clearly not supported since they don't fit in one char. ------------- Marked as reviewed by dfuchs (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/33232#pullrequestreview-5681567452
