On Mon, 26 Oct 2026 10:10:37 GMT, Jaikiran Pai <[email protected]> wrote:
> Maybe rename the method to `eqHashCompBidi`? Changed in e1b8e336058. > I think it would be better to change the method to accept only `URI` > instances, instead of `Object`, and then have the call sites convert the > `String` to `URI`. > ... > instead of `expectedRelation` being a `String`, perhaps make it a `enum`? I experimented with all these configurations prior to submitting the PR and concluded that the current state of things provide a sufficient API clarity for this internal test helper method and shorten the test expression (i.e., the call-site) to a minimum without introducing any cryptic syntax. `enum`, `URI`, etc. added just extra boilerplate without any convenience, AFAICT. I'm inclined to keep `Object` & `String` (which I later on further simplified to `char` in 94633f1e8e0) unless you have an objection. @jaikiran, please let me know of your conclusive preference. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33232#discussion_r4379178465
