linuxppc-dev

Messages by Date

2026/02/27 Re: [PATCH 24/25] xor: pass the entire operation to the low-level ops Eric Biggers
2026/02/27 Re: [PATCH 22/25] async_xor: use xor_gen Eric Biggers
2026/02/27 Re: [PATCH 21/25] xor: add a better public API Eric Biggers
2026/02/27 Re: [PATCH 20/25] xor: make xor.ko self-contained in lib/raid/ Eric Biggers
2026/02/27 Re: [bug report] Bug: Write fault blocked by KUAP! Changhui Zhong
2026/02/27 Re: [PATCH 16/25] sparc: move the XOR code to lib/raid/ Eric Biggers
2026/02/27 Re: [PATCH 15/25] riscv: move the XOR code to lib/raid/ Eric Biggers
2026/02/27 Re: [PATCH 07/25] xor: split xor.h Eric Biggers
2026/02/27 Re: [PATCH 06/25] xor: cleanup registration and probing Eric Biggers
2026/02/27 Re: [PATCH 04/25] xor: move to lib/raid/ Eric Biggers
2026/02/27 Re: [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE Eric Biggers
2026/02/27 Re: powerpc/fadump: CMA init is failing IBM
2026/02/27 Re: [PATCH v7 3/5] crash: Use crash_exclude_core_ranges() on powerpc Jinjie Ruan
2026/02/27 Re: [RFC v2 00/21] mm: thp: lazy PTE page table allocation at PMD split Nico Pache
2026/02/27 Re: [PATCH 18/25] x86: move the XOR code to lib/raid/ Eric Biggers
2026/02/27 Re: [PATCH v6 01/13] mm/migrate_device: Introduce migrate_pfn_from_page() helper David Hildenbrand (Arm)
2026/02/27 Re: powerpc/fadump: CMA init is failing Mike Rapoport
2026/02/27 Re: [PATCH] mm/hugetlb.c: Use __pa() instead of virt_to_phys() in early bootmem alloc code Mike Rapoport
2026/02/27 Re: [PATCH v3 23/29] arch, mm: consolidate initialization of nodes, zones and memory map Mike Rapoport
2026/02/27 [PATCH v1 16/16] mm/memory: support VM_MIXEDMAP in zap_special_vma_range() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 15/16] mm: rename zap_vma_ptes() to zap_special_vma_range() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 14/16] mm: rename zap_page_range_single() to zap_vma_range() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 13/16] mm: rename zap_page_range_single_batched() to zap_vma_range_batched() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 12/16] mm: rename zap_vma_pages() to zap_vma() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 11/16] mm/memory: inline unmap_page_range() into __zap_vma_range() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 10/16] mm/memory: use __zap_vma_range() in zap_vma_for_reaping() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 09/16] mm/memory: convert details->even_cows into details->skip_cows David Hildenbrand (Arm)
2026/02/27 [PATCH v1 08/16] mm/memory: move adjusting of address range to unmap_vmas() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 07/16] mm/memory: rename unmap_single_vma() to __zap_vma_range() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 06/16] mm/oom_kill: factor out zapping of VMA into zap_vma_for_reaping() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 05/16] mm/oom_kill: use MMU_NOTIFY_CLEAR in __oom_reap_task_mm() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 04/16] mm/memory: simplify calculation in unmap_mapping_range_tree() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 03/16] mm/memory: inline unmap_mapping_range_vma() into unmap_mapping_range_tree() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 02/16] mm/memory: remove "zap_details" parameter from zap_page_range_single() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 01/16] mm/madvise: drop range checks in madvise_free_single_vma() David Hildenbrand (Arm)
2026/02/27 [PATCH v1 00/16] mm: cleanups around unmapping / zapping David Hildenbrand (Arm)
2026/02/27 Re: [PATCH 1/2] ima: efi: Drop unnecessary check for CONFIG_MODULE_SIG/CONFIG_KEXEC_SIG Mimi Zohar
2026/02/27 Re: powerpc/fadump: CMA init is failing IBM
2026/02/27 [PATCH v2] powerpc/crash: adjust the elfcorehdr size Sourabh Jain
2026/02/27 Re: [PATCH v4 1/4] PCI/MSI: Conservatively generalize no_64bit_msi into msi_addr_mask Bjorn Helgaas
2026/02/27 Re: [PATCHv2 0/2] pci: fix msi_addr_mask on powerpc and sparc systems Bjorn Helgaas
2026/02/27 Re: [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific printk helpers Johan Hovold
2026/02/27 Re: [PATCH 1/2] kbuild: Consolidate C dialect options Nicolas Schier
2026/02/27 Re: [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific printk helpers Bartosz Golaszewski
2026/02/27 Re: [PATCH v2 0/4] powerpc64/bpf: Add support for instruction array and indirect jump Venkat
2026/02/27 powerpc/fadump: CMA init is failing Sourabh Jain
2026/02/27 Re: [PATCH v3 23/29] arch, mm: consolidate initialization of nodes, zones and memory map Vlastimil Babka
2026/02/27 Re: [PATCH v7 3/5] crash: Use crash_exclude_core_ranges() on powerpc Sourabh Jain
2026/02/27 Re: [PATCH v7 3/5] crash: Use crash_exclude_core_ranges() on powerpc Sourabh Jain
2026/02/27 Re: [PATCH 25/25] xor: use static_call for xor_gen Peter Zijlstra
2026/02/27 Re: [PATCH 18/25] x86: move the XOR code to lib/raid/ Peter Zijlstra
2026/02/27 Re: [PATCH 01/25] xor: assert that xor_blocks is not called from interrupt context Peter Zijlstra
2026/02/27 Re: [PATCH 17/25] s390: move the XOR code to lib/raid/ Christoph Hellwig
2026/02/27 Re: [PATCH v7 2/5] PCI/DPC: Run recovery on device that detected the error Shuai Xue
2026/02/27 Re: [RFC v1 2/2] powerpc/64s: Add support for huge pfnmaps IBM
2026/02/27 Re: [RFC v2 13/21] mm: huge_mm: Make sure all split_huge_pmd calls are checked Usama Arif
2026/02/27 Re: [RFC v2 00/21] mm: thp: lazy PTE page table allocation at PMD split Usama Arif
2026/02/27 Re: [PATCH v7 2/5] PCI/DPC: Run recovery on device that detected the error Lukas Wunner
2026/02/27 Re: [RFC v1 1/2] drivers/vfio_pci_core: Change PXD_ORDER check from switch case to if/else block IBM
2026/02/27 Re: [PATCH 5/7] MIPS: VDSO: Drop kconfig MIPS_CLOCK_VSYSCALL Thomas Weißschuh
2026/02/27 Re: [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific printk helpers Johan Hovold
2026/02/27 Re: [PATCH 5/7] MIPS: VDSO: Drop kconfig MIPS_CLOCK_VSYSCALL Arnd Bergmann
2026/02/27 Re: [PATCH v4 1/4] PCI/MSI: Conservatively generalize no_64bit_msi into msi_addr_mask Mark Bloch
2026/02/27 Re: [PATCH 1/7] x86/vdso: Respect COMPAT_32BIT_TIME Thomas Weißschuh
2026/02/27 Re: [PATCH 5/7] MIPS: VDSO: Drop kconfig MIPS_CLOCK_VSYSCALL Thomas Weißschuh
2026/02/27 Re: [PATCH 1/2] powerpc: fix KUAP warning in VMX usercopy path Christophe Leroy (CS GROUP)
2026/02/27 Re: [PATCH 17/25] s390: move the XOR code to lib/raid/ Heiko Carstens
2026/02/27 Re: [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific printk helpers Wolfram Sang
2026/02/27 Re: [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific printk helpers Johan Hovold
2026/02/27 Re: [PATCH 1/7] x86/vdso: Respect COMPAT_32BIT_TIME Arnd Bergmann
2026/02/27 Re: [PATCH v3 3/3] mm: use vma_start_write_killable() in process_vma_walk_lock() Claudio Imbrenda
2026/02/27 Re: [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific printk helpers Wolfram Sang
2026/02/27 Re: [PATCH 1/7] x86/vdso: Respect COMPAT_32BIT_TIME Arnd Bergmann
2026/02/27 Re: [PATCH 7/7] vdso/gettimeofday: Verify COMPAT_32BIT_TIME interactions Arnd Bergmann
2026/02/27 Re: [PATCH 5/7] MIPS: VDSO: Drop kconfig MIPS_CLOCK_VSYSCALL Arnd Bergmann
2026/02/27 Re: [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific printk helpers Bartosz Golaszewski
2026/02/27 Re: [PATCH v6 0/6] Extend "trusted" keys to support a new trust source named the PowerVM Key Wrapping Module (PKWM) Srish Srinivasan
2026/02/27 Re: [PATCH v7 2/5] PCI/DPC: Run recovery on device that detected the error Shuai Xue
2026/02/27 [PATCH] powerpc, perf: Check that current->mm is alive before getting user callchain Viktor Malik
2026/02/26 Re: [PATCH v6 0/6] Extend "trusted" keys to support a new trust source named the PowerVM Key Wrapping Module (PKWM) Christophe Leroy (CS GROUP)
2026/02/26 Re: [next-20260226] static assertion failure in amdgv_sriovmsg.h Venkat Rao Bagalkote
2026/02/26 Re: [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE Johannes Berg
2026/02/26 [next-20260226] static assertion failure in amdgv_sriovmsg.h Venkat Rao Bagalkote
2026/02/26 [PATCH 2/7] ARM: VDSO: Respect COMPAT_32BIT_TIME Thomas Weißschuh
2026/02/26 [PATCH 7/7] vdso/gettimeofday: Verify COMPAT_32BIT_TIME interactions Thomas Weißschuh
2026/02/26 [PATCH 6/7] MIPS: VDSO: Respect COMPAT_32BIT_TIME Thomas Weißschuh
2026/02/26 [PATCH 4/7] powerpc/vdso: Respect COMPAT_32BIT_TIME Thomas Weißschuh
2026/02/26 [PATCH 5/7] MIPS: VDSO: Drop kconfig MIPS_CLOCK_VSYSCALL Thomas Weißschuh
2026/02/26 [PATCH 3/7] arm64: vdso32: Respect COMPAT_32BIT_TIME Thomas Weißschuh
2026/02/26 [PATCH 0/7] vDSO: Respect COMPAT_32BIT_TIME Thomas Weißschuh
2026/02/26 [PATCH 1/7] x86/vdso: Respect COMPAT_32BIT_TIME Thomas Weißschuh
2026/02/26 [PATCH v2] powerpc: Implement ARCH_HAS_CC_CAN_LINK Thomas Weißschuh
2026/02/26 Re: [RFC v1 2/2] powerpc/64s: Add support for huge pfnmaps Christophe Leroy (CS GROUP)
2026/02/26 [PATCH v2 11/15] vdso/helpers: Explicitly include vdso/processor.h Thomas Weißschuh
2026/02/26 [PATCH v2 13/15] vdso/datapage: Trim down unnecessary includes Thomas Weißschuh
2026/02/26 [PATCH v2 04/15] powerpc/vdso/gettimeofday: Explicitly include vdso/time32.h Thomas Weißschuh
2026/02/26 [PATCH v2 08/15] MIPS: vdso: Explicitly include asm/vdso/vdso.h Thomas Weißschuh
2026/02/26 [PATCH v2 09/15] random: vDSO: add explicit includes Thomas Weißschuh
2026/02/26 [PATCH v2 15/15] random: vDSO: remove ifdeffery Thomas Weißschuh
2026/02/26 [PATCH v2 10/15] vdso/gettimeofday: Add explicit includes Thomas Weißschuh
2026/02/26 [PATCH v2 06/15] LoongArch: vDSO: Explicitly include asm/vdso/vdso.h Thomas Weißschuh
2026/02/26 [PATCH v2 14/15] random: vDSO: trim vDSO includes Thomas Weißschuh
2026/02/26 [PATCH v2 07/15] MIPS: vdso: Add include guard to asm/vdso/vdso.h Thomas Weißschuh
2026/02/26 [PATCH v2 12/15] vdso/datapage: Remove inclusion of gettimeofday.h Thomas Weißschuh
2026/02/26 [PATCH v2 05/15] powerpc/vdso: Explicitly include asm/cputable.h and asm/feature-fixups.h Thomas Weißschuh
2026/02/26 [PATCH v2 00/15] vDSO: header file cleanups Thomas Weißschuh
2026/02/26 [PATCH v2 01/15] arm64: vDSO: gettimeofday: Explicitly include vdso/clocksource.h Thomas Weißschuh
2026/02/26 [PATCH v2 02/15] arm64: vDSO: compat_gettimeofday: Add explicit includes Thomas Weißschuh
2026/02/26 [PATCH v2 03/15] ARM: vdso: gettimeofday: Add explicit includes Thomas Weißschuh
2026/02/26 Re: [RFC v1 1/2] drivers/vfio_pci_core: Change PXD_ORDER check from switch case to if/else block Christophe Leroy (CS GROUP)
2026/02/26 [RFC v1 2/2] powerpc/64s: Add support for huge pfnmaps Ritesh Harjani (IBM)
2026/02/26 [RFC v1 1/2] drivers/vfio_pci_core: Change PXD_ORDER check from switch case to if/else block Ritesh Harjani (IBM)
2026/02/26 Re: [PATCH v4 1/4] PCI/MSI: Conservatively generalize no_64bit_msi into msi_addr_mask Vivian Wang
2026/02/26 Re: [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE hch
2026/02/26 Re: [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE Richard Weinberger
2026/02/26 Re: [PATCH v3 2/3] mm: replace vma_start_write() with vma_start_write_killable() Suren Baghdasaryan
2026/02/26 Re: [PATCH v1] ALSA: aoa: Constify struct configfs_item_operations and configfs_group_operations Johannes Berg
2026/02/26 [PATCH v1] ALSA: aoa: Constify struct codec_connection Christophe JAILLET
2026/02/26 [PATCH v1] ALSA: aoa: Constify struct configfs_item_operations and configfs_group_operations Christophe JAILLET
2026/02/26 Re: [PATCH v4 1/4] PCI/MSI: Conservatively generalize no_64bit_msi into msi_addr_mask Mark Bloch
2026/02/26 Re: [RFC v2 00/21] mm: thp: lazy PTE page table allocation at PMD split Nico Pache
2026/02/26 Re: [PATCH v1] ALSA: aoa: Constify struct configfs_item_operations and configfs_group_operations Christophe JAILLET
2026/02/26 [PATCH v2 4/4] selftest/bpf: Enable gotox tests for powerpc64 adubey
2026/02/26 [PATCH v2 3/4] powerpc64/bpf: Add support for indirect jump adubey
2026/02/26 [PATCH v2 2/4] selftest/bpf: Enable instruction array test for powerpc64 adubey
2026/02/26 [PATCH v2 1/4] powerpc64/bpf: Add support for instruction array adubey
2026/02/26 [PATCH v2 0/4] powerpc64/bpf: Add support for instruction array and indirect jump adubey
2026/02/26 Re: [PATCH v2 00/13] i2c: add and start using i2c_adapter-specific printk helpers Wolfram Sang
2026/02/26 Re: [PATCH] powerpc/ps3: fix ps3.h kernel-doc warnings Randy Dunlap
2026/02/26 Re: [bug report] Bug: Write fault blocked by KUAP! Christophe Leroy (CS GROUP)
2026/02/26 Re: [PATCH v3 3/3] mm: use vma_start_write_killable() in process_vma_walk_lock() Suren Baghdasaryan
2026/02/26 Re: cleanup the RAID5 XOR library Andrew Morton
2026/02/26 Re: [PATCH v3 3/3] mm: use vma_start_write_killable() in process_vma_walk_lock() Claudio Imbrenda
2026/02/26 Re: [PATCH v3 2/3] mm: replace vma_start_write() with vma_start_write_killable() Liam R. Howlett
2026/02/26 Re: [PATCH v3 1/3] mm/vma: cleanup error handling path in vma_expand() Suren Baghdasaryan
2026/02/26 Re: [bug report] Bug: Write fault blocked by KUAP! Caleb Sander Mateos
2026/02/26 Re: [PATCH v3 1/3] mm/vma: cleanup error handling path in vma_expand() Liam R. Howlett
2026/02/26 Re: [PATCH 09/25] xor: move generic implementations out of asm-generic/xor.h Arnd Bergmann
2026/02/26 [PATCH 24/25] xor: pass the entire operation to the low-level ops Christoph Hellwig
2026/02/26 [PATCH 25/25] xor: use static_call for xor_gen Christoph Hellwig
2026/02/26 [PATCH 23/25] btrfs: use xor_gen Christoph Hellwig
2026/02/26 [PATCH 21/25] xor: add a better public API Christoph Hellwig
2026/02/26 [PATCH 22/25] async_xor: use xor_gen Christoph Hellwig
2026/02/26 [PATCH 20/25] xor: make xor.ko self-contained in lib/raid/ Christoph Hellwig
2026/02/26 [PATCH 18/25] x86: move the XOR code to lib/raid/ Christoph Hellwig
2026/02/26 [PATCH 19/25] xor: avoid indirect calls for arm64-optimized ops Christoph Hellwig
2026/02/26 [PATCH 16/25] sparc: move the XOR code to lib/raid/ Christoph Hellwig
2026/02/26 [PATCH 17/25] s390: move the XOR code to lib/raid/ Christoph Hellwig
2026/02/26 [PATCH 10/25] alpha: move the XOR code to lib/raid/ Christoph Hellwig
2026/02/26 [PATCH 14/25] powerpc: move the XOR code to lib/raid/ Christoph Hellwig
2026/02/26 [PATCH 09/25] xor: move generic implementations out of asm-generic/xor.h Christoph Hellwig
2026/02/26 [PATCH 11/25] arm: move the XOR code to lib/raid/ Christoph Hellwig
2026/02/26 [PATCH 15/25] riscv: move the XOR code to lib/raid/ Christoph Hellwig
2026/02/26 [PATCH 13/25] loongarch: move the XOR code to lib/raid/ Christoph Hellwig
2026/02/26 [PATCH 12/25] arm64: move the XOR code to lib/raid/ Christoph Hellwig
2026/02/26 [PATCH 08/25] xor: remove macro abuse for XOR implementation registrations Christoph Hellwig
2026/02/26 [PATCH 06/25] xor: cleanup registration and probing Christoph Hellwig
2026/02/26 [PATCH 05/25] xor: small cleanups Christoph Hellwig
2026/02/26 [PATCH 07/25] xor: split xor.h Christoph Hellwig
2026/02/26 [PATCH 03/25] um/xor: don't override XOR_SELECT_TEMPLATE Christoph Hellwig
2026/02/26 [PATCH 02/25] arm/xor: remove in_interrupt() handling Christoph Hellwig
2026/02/26 cleanup the RAID5 XOR library Christoph Hellwig
2026/02/26 [PATCH 01/25] xor: assert that xor_blocks is not called from interrupt context Christoph Hellwig
2026/02/26 [PATCH 04/25] xor: move to lib/raid/ Christoph Hellwig
2026/02/26 Re: [RFC v2 16/21] mm: thp: add THP_SPLIT_PMD_FAILED counter Usama Arif
2026/02/26 Re: [Linux PPC] Disable PREEMPT Christophe Leroy (CS GROUP)
2026/02/26 [PATCH v7 5/5] riscv: kexec: Add support for crashkernel CMA reservation Jinjie Ruan
2026/02/26 [PATCH v7 4/5] arm64: kexec: Add support for crashkernel CMA reservation Jinjie Ruan
2026/02/26 [PATCH v7 1/5] powerpc/crash: sort crash memory ranges before preparing elfcorehdr Jinjie Ruan
2026/02/26 [PATCH v7 3/5] crash: Use crash_exclude_core_ranges() on powerpc Jinjie Ruan
2026/02/26 [PATCH v7 0/5] arm64/riscv: Add support for crashkernel CMA reservation Jinjie Ruan
2026/02/26 [PATCH v7 2/5] crash: Exclude crash kernel memory in crash core Jinjie Ruan
2026/02/26 Re: [PATCH 04/15] powerpc/time: Prepare to stop elapsing in dynticks-idle Shrikanth Hegde
2026/02/26 Re: [bug report] Bug: Write fault blocked by KUAP! Ming Lei
2026/02/26 Re: [PATCH v6 2/5] crash: Exclude crash kernel memory in crash core Baoquan He
2026/02/26 Re: [PATCH v6 1/5] powerpc/crash: sort crash memory ranges before preparing elfcorehdr Baoquan He
2026/02/26 [PATCH] mm/hugetlb.c: Use __pa() instead of virt_to_phys() in early bootmem alloc code Ritesh Harjani (IBM)
2026/02/26 Re: [PATCH] powerpc/ps3: fix ps3.h kernel-doc warnings Christophe Leroy (CS GROUP)
2026/02/26 [RFC v2 21/21] selftests/mm: add madv_dontneed_partial test Usama Arif
2026/02/26 [RFC v2 20/21] selftests/mm: add partial_mremap test for move_page_tables Usama Arif
2026/02/26 [RFC v2 19/21] selftests/mm: add partial_mlock test Usama Arif
2026/02/26 [RFC v2 18/21] selftests/mm: add partial_mprotect test for change_pmd_range Usama Arif
2026/02/26 [RFC v2 17/21] selftests/mm: add THP PMD split test infrastructure Usama Arif
2026/02/26 [RFC v2 16/21] mm: thp: add THP_SPLIT_PMD_FAILED counter Usama Arif
2026/02/26 [RFC v2 15/21] mm: thp: remove pgtable_trans_huge_{deposit/withdraw} when not needed Usama Arif
2026/02/26 [RFC v2 14/21] mm: thp: allocate PTE page tables lazily at split time Usama Arif
2026/02/26 [RFC v2 13/21] mm: huge_mm: Make sure all split_huge_pmd calls are checked Usama Arif
2026/02/26 [RFC v2 12/21] mm: thp: handle split failure in device migration Usama Arif
2026/02/26 [RFC v2 11/21] mm: thp: handle split failure in userfaultfd move_pages() Usama Arif
2026/02/26 [RFC v2 10/21] mm: thp: handle split failure in mremap move_page_tables() Usama Arif
2026/02/26 [RFC v2 08/21] mm: thp: handle split failure in follow_pmd_mask() Usama Arif
2026/02/26 [RFC v2 09/21] mm: handle walk_page_range() failure from THP split Usama Arif
2026/02/26 [RFC v2 07/21] mm: thp: retry on split failure in change_pmd_range() Usama Arif
2026/02/26 [RFC v2 06/21] mm: thp: handle split failure in wp_huge_pmd() Usama Arif
2026/02/26 [RFC v2 05/21] mm: thp: handle split failure in zap_pmd_range() Usama Arif
2026/02/26 [RFC v2 04/21] mm: thp: handle split failure in do_huge_pmd_wp_page() Usama Arif
2026/02/26 [RFC v2 03/21] mm: thp: handle split failure in copy_huge_pmd() Usama Arif
2026/02/26 [RFC v2 02/21] mm: thp: propagate split failure from vma_adjust_trans_huge() Usama Arif
2026/02/26 [RFC v2 00/21] mm: thp: lazy PTE page table allocation at PMD split Usama Arif
2026/02/26 [RFC v2 01/21] mm: thp: make split_huge_pmd functions return int for error propagation Usama Arif