[GitHub] [kafka] big-andy-coates commented on a change in pull request #9156: KAFKA-10077: Filter downstream of state-store results in spurious tombstones

[GitBox]

big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r480997443



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java
##########
@@ -203,6 +203,10 @@ public String queryableStoreName() {
             processorSupplier,
             tableNode,
             builder);
+
+        kTable.enableSendingOldValues();

Review comment:
       If we call `this.enableSendingOldValues()` then `enableSendingOldValues` 
is not called on the `KTableFilter` instance. Whereas calling 
`kTable.enableSendingOldValues()` does call 
`KTableFilter.enableSendingOldValues()`.
   
   The call to `KTableFilter.enableSendingOldValues()` is needed to ensure the 
filter expects the old values.
   
   Is it more correct to call `enableSOV` on both the filter and `this` 
explicitly, so that the downstream `kTable` doesn't have it set?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org