big-andy-coates commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r487060078
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableKTableAbstractJoin.java
##########
@@ -39,9 +39,15 @@
}
@Override
- public final void enableSendingOldValues() {
- table1.enableSendingOldValues();
- table2.enableSendingOldValues();
+ public final boolean enableSendingOldValues(final boolean
onlyIfMaterialized) {
+ if (!table1.enableSendingOldValues(onlyIfMaterialized)) {
+ throw new IllegalStateException("Table-table joins should always
be materialized");
+ }
+
+ if (!table2.enableSendingOldValues(onlyIfMaterialized)) {
Review comment:
as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
