mjsax commented on a change in pull request #9156:
URL: https://github.com/apache/kafka/pull/9156#discussion_r477622476
##########
File path:
streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java
##########
@@ -123,7 +123,7 @@ public void shouldAllowJoinMaterializedFilteredKTable() {
assertThat(
topology.stateStores().size(),
- equalTo(1));
+ equalTo(2));
Review comment:
@guozhangwang Atm, when `enableSendingOldValues` is set and the upstream
store is not materialized already we enforce a materialization. Thus, enabling
`enableSendingOldValues` in `KTable#filter()` would be a breaking change as we
would start to materialize state that did not exist before if one upgrades a
topology.
Instead, we want to say, _iff_ the upstream store exist, please send me the
old value, but if the upstream store does not exist, it's ok to just send
`old=null` but don't force a materialization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
