OmniaGM commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2044964750
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##########
@@ -2339,80 +2357,90 @@ public void
testBumpEpochWhenOutOfOrderSequenceReceived() throws InterruptedExce
@Test
public void testIdempotentSplitBatchAndSend() throws Exception {
- TopicPartition tp = new TopicPartition("testSplitBatchAndSend", 1);
+ Uuid topicId = Uuid.fromString("2J9hK8m1wHMKjXfIkQyXx1");
+ TOPIC_IDS.put("testSplitBatchAndSend", topicId);
+ TopicIdPartition tpId = new TopicIdPartition(topicId, new
TopicPartition("testSplitBatchAndSend", 1));
TransactionManager txnManager = createTransactionManager();
ProducerIdAndEpoch producerIdAndEpoch = new
ProducerIdAndEpoch(123456L, (short) 0);
setupWithTransactionState(txnManager);
prepareAndReceiveInitProducerId(123456L, Errors.NONE);
assertTrue(txnManager.hasProducerId());
- testSplitBatchAndSend(txnManager, producerIdAndEpoch, tp);
+ testSplitBatchAndSend(txnManager, producerIdAndEpoch, tpId);
}
@Test
public void testTransactionalSplitBatchAndSend() throws Exception {
+ Uuid topicId = Uuid.fromString("2J9hK8m1wHMKjXfIkQyXx1");
+ TOPIC_IDS.put("testSplitBatchAndSend", topicId);
Review Comment:
They are the same topic ids and name. I am not sure if the topic name and id
should move to the setup of the test suite as multiple test cases need this
topic. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
