OmniaGM commented on code in PR #15968:
URL: https://github.com/apache/kafka/pull/15968#discussion_r2044962640
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##########
@@ -153,9 +155,12 @@ public class SenderTest {
private static final int DELIVERY_TIMEOUT_MS = 1500;
private static final long TOPIC_IDLE_MS = 60 * 1000;
- private final TopicPartition tp0 = new TopicPartition("test", 0);
- private final TopicPartition tp1 = new TopicPartition("test", 1);
- private final TopicPartition tp2 = new TopicPartition("test", 2);
+ private static final String TOPIC_NAME = "test";
+ private static final Uuid TOPIC_ID =
Uuid.fromString("MKXx1fIkQy2J9jXHhK8m1w");
+ private static final Map<String, Uuid> TOPIC_IDS = new
HashMap<>(Map.of(TOPIC_NAME, TOPIC_ID));
Review Comment:
`Map.of` create immutable map which can't be edited later to add other
topics needed for other test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
