epugh commented on code in PR #4721:
URL: https://github.com/apache/solr/pull/4721#discussion_r3749680609
##########
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##########
@@ -846,18 +846,19 @@ public static void assertQ(SolrQueryRequest req,
String... tests) {
assertQ(null, req, tests);
}
- /** Validates a query matches some XPath test expressions and closes the
query */
- public static void assertQ(String message, SolrQueryRequest req, String...
tests) {
- assertQ(message, req.getParams().get(CommonParams.QT), req, tests);
- }
-
/**
- * Validates a query against the named handler matches some XPath test
expressions and closes the
- * query
+ * The handler that should process {@code req}: its {@link
SolrQueryRequest#getPath()} if set,
+ * otherwise falls back to the deprecated "qt" request param.
Review Comment:
out of curiosity, would it make sense to have some sort of warning be logged
about using the deprecated qt? assuming you don't finish the migration, then
others might see the message and pick up on it?
Kind of like we emit a warning for deprecated system environment names.
Though with the verbosity that our tests have, maybe no one sees it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
