gerlowskija commented on code in PR #4721:
URL: https://github.com/apache/solr/pull/4721#discussion_r3749662920
##########
solr/core/src/test/org/apache/solr/handler/component/QueryElevationComponentTest.java:
##########
@@ -1166,6 +1137,8 @@ public void testSorting() throws Exception {
// now switch the order:
booster.setTopQueryResults(reader, query, false, new String[] {"a",
"x"}, null);
assertQ(
+ null,
Review Comment:
I ended up going the `reqWithPath` route here.
To answer my earlier question:`SQR.getPath` is used in production code but
prior to this PR wasn't really used anywhere in tests, but there doesn't
(afaict) appear to be any driving reason for that - it's just a consequence of
how 'assertQ' and other helpers call `TestHarness.query()` rather than
submitting a full HTTP request and utilizing Solr servers "natural" dispatching
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
