gerlowskija commented on code in PR #4721:
URL: https://github.com/apache/solr/pull/4721#discussion_r3752734558
##########
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##########
@@ -846,18 +846,19 @@ public static void assertQ(SolrQueryRequest req,
String... tests) {
assertQ(null, req, tests);
}
- /** Validates a query matches some XPath test expressions and closes the
query */
- public static void assertQ(String message, SolrQueryRequest req, String...
tests) {
- assertQ(message, req.getParams().get(CommonParams.QT), req, tests);
- }
-
/**
- * Validates a query against the named handler matches some XPath test
expressions and closes the
- * query
+ * The handler that should process {@code req}: its {@link
SolrQueryRequest#getPath()} if set,
+ * otherwise falls back to the deprecated "qt" request param.
Review Comment:
Good question, idk.
If we do anything, I think deprecating `CommonParams.QT` might be a better
route.
That would gives devs a visible signal in their IDE's without being a
massive source of noise in the tests. If we logged a warning right now I think
it'd be very very erbose. There's still > 500 usages of this in test helpers,
let alone any production code that's currently using it that the tests would
trigger. A log.warn seems better once (a) the volume is much lower than it
currently is and (b) we've got a plan for the remaining usages of QT on the
server side and are certain that the deprecation will "stick".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
