epugh commented on code in PR #4721:
URL: https://github.com/apache/solr/pull/4721#discussion_r3753061753
##########
solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java:
##########
@@ -846,18 +846,19 @@ public static void assertQ(SolrQueryRequest req,
String... tests) {
assertQ(null, req, tests);
}
- /** Validates a query matches some XPath test expressions and closes the
query */
- public static void assertQ(String message, SolrQueryRequest req, String...
tests) {
- assertQ(message, req.getParams().get(CommonParams.QT), req, tests);
- }
-
/**
- * Validates a query against the named handler matches some XPath test
expressions and closes the
- * query
+ * The handler that should process {@code req}: its {@link
SolrQueryRequest#getPath()} if set,
+ * otherwise falls back to the deprecated "qt" request param.
Review Comment:
Yeah... We actually DID have `CommonParams.QT` deprecated, and then it got
undeprecated a few months ago due (some reasons I don't recall right now! )
Maybe streaming and sql usage? But they have been fixed..
agreed we have to have a plan for the production code... I'm assuming
these test changes are pretty mechanical?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
