gerlowskija commented on code in PR #4721:
URL: https://github.com/apache/solr/pull/4721#discussion_r3745010227
##########
solr/core/src/test/org/apache/solr/handler/component/QueryElevationComponentTest.java:
##########
@@ -1663,9 +1598,9 @@ public void
testOnlyRepresentativeIsVisibleWhenCollapsing() throws Exception {
// only representative elevated doc visible
assertQ(
"",
Review Comment:
In theory, I agree. In practice:
1. It's hard to write a good error message for an assertion like this that's
running many XPath checks. Taking this particular case as an example: what
would a good message look like, that's better than what assertQ does by default
(which prints both the XPath expression that caused the failure and
corresponding section of the results)?
2. Bandwidth. If I stop to spruce up every little thing that *could* be
improved I'm worried the larger qt effort will never get across the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
