epugh commented on code in PR #4721:
URL: https://github.com/apache/solr/pull/4721#discussion_r3744055147
##########
solr/core/src/test/org/apache/solr/handler/component/QueryElevationComponentTest.java:
##########
@@ -1166,6 +1137,8 @@ public void testSorting() throws Exception {
// now switch the order:
booster.setTopQueryResults(reader, query, false, new String[] {"a",
"x"}, null);
assertQ(
+ null,
Review Comment:
Is this null because you didn't want to add a message on failure?
##########
solr/core/src/test/org/apache/solr/handler/component/QueryElevationComponentTest.java:
##########
@@ -1663,9 +1598,9 @@ public void
testOnlyRepresentativeIsVisibleWhenCollapsing() throws Exception {
// only representative elevated doc visible
assertQ(
"",
Review Comment:
I think it's worth adding a proper message in for the `null` or `""`, and
the failure messages help you understand what the test is about..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
