mlbiscoc commented on code in PR #2935:
URL: https://github.com/apache/solr/pull/2935#discussion_r1910697779
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##########
@@ -61,6 +67,7 @@ public abstract class BaseHttpClusterStateProvider implements
ClusterStateProvid
private int cacheTimeout =
EnvUtils.getPropertyAsInteger("solr.solrj.cache.timeout.sec", 5);
public void init(List<String> solrUrls) throws Exception {
+ this.initialNodes = getNodeNamesFromSolrUrls(solrUrls);
Review Comment:
> I think the idea of this JIRA issue is that we'll take the Solr URLs as
configured and use this is the initial / backup liveNodes. I think this is a
very simple idea to to document/understand/implement.
That makes sense. This leaves me with a few questions then. Shouldn't this
take a list of `URL` or `URI` java object to verify actual non malformed URLs
instead of a list of strings? I created the functions below to convert these
Strings into cluster state nodeNames for `liveNodes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
