HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1817369402
##########
solr/test-framework/build.gradle:
##########
@@ -43,6 +43,17 @@ dependencies {
var zkExcludes = {
exclude group: "org.apache.yetus", module: "audience-annotations"
}
+ api('org.apache.curator:curator-client', {
Review Comment:
I've changed all curator deps here to "implementation"
##########
solr/solrj-zookeeper/build.gradle:
##########
@@ -32,6 +32,13 @@ dependencies {
implementation project(':solr:solrj')
+ api('org.apache.curator:curator-client', {
Review Comment:
Actually implementation should be ok for the `curator-client`. For
`curator-framework`, that wouldn't be great because of the
`SolrZkClient.multi()` function parameters.
##########
gradle/testing/randomization/policies/solr-tests.policy:
##########
@@ -50,6 +50,7 @@ grant {
permission java.net.SocketPermission "127.0.0.1:4", "connect,resolve";
permission java.net.SocketPermission "127.0.0.1:6", "connect,resolve";
permission java.net.SocketPermission "127.0.0.1:8", "connect,resolve";
+ permission java.net.SocketPermission "----------", "connect,resolve";
Review Comment:
It's a fake ZK host used in a test, just like all of the other ones. But I
added a comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
