HoustonPutman commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1819484898


##########
solr/solrj-streaming/src/test/org/apache/solr/client/solrj/io/stream/BadClusterTest.java:
##########
@@ -97,15 +102,15 @@ private void testAllNodesDown() throws Exception {
   }
 
   private void testClusterShutdown() throws Exception {
-
-    CloudSolrStream stream = new CloudSolrStream(buildSearchExpression(), 
streamFactory);
     cluster.shutdown();
 
-    try {
-      getTuples(stream);
-      fail("Expected IOException: SolrException: TimeoutException");
-    } catch (IOException ioe) {
-      SolrException se = (SolrException) ioe.getCause();
+    try (CloudSolrClient cloudSolrClient =
+        new CloudHttp2SolrClient.Builder(Collections.singletonList(zkHost), 
Optional.empty())
+            .withZkConnectTimeout(1, TimeUnit.SECONDS)
+            .build()) {
+      cloudSolrClient.getById(collection, "1");

Review Comment:
   I'll revert. The test will just be slow until 
https://issues.apache.org/jira/browse/CURATOR-720 is implemented.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to