dsmiley commented on code in PR #760:
URL: https://github.com/apache/solr/pull/760#discussion_r1815068705
##########
gradle/testing/randomization/policies/solr-tests.policy:
##########
@@ -50,6 +50,7 @@ grant {
permission java.net.SocketPermission "127.0.0.1:4", "connect,resolve";
permission java.net.SocketPermission "127.0.0.1:6", "connect,resolve";
permission java.net.SocketPermission "127.0.0.1:8", "connect,resolve";
+ permission java.net.SocketPermission "----------", "connect,resolve";
Review Comment:
What's this? A comment could be useful.
##########
solr/CHANGES.txt:
##########
@@ -23,6 +23,8 @@ Improvements
* SOLR-17077: When a shard rejoins leader election, leave previous election
only once to save unneeded calls to Zookeeper. (Pierre Salagnac)
+* SOLR-16116: Apache Curator is now used to manage all Solr Zookeeper
interactions. (Houston Putman, Kevin Risden, Mike Drob, David Smiley)
Review Comment:
I think my role was minor.
BTW this PR adds a dependency to Curator from solrj-zookeeper. We should
highlight solrj dependencies with more publicity than Solr server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
